Finish Removing golint (#1746)

* Set GO111MODULE to auto in golint script– #1743

As mentioned in #1743 the Go modules environment flag is set to `off`
in the script which appears to cause a warning message for each module
of the codebase that it is "not in GOROOT".

Set to `auto` as this allows the same build to be run the original way
should someone choose to delete the `go.mod` file from the project root.

* Remove redundant code – golint script

Go 1.17 ignores `GO111MODULE` and there are no directories in the
project root called `mock`.

* Replace `golint` with `go vet`

`golint` is deprecated (and frozen) replace with the current `go vet`.
This reported one issue on `main` branch:
```pkg/stash/with_etcd.go:33:28:
loop variable ep captured by func literal```

Fixed loop variable capture with extraction to parameterised anonymous
function passed loop variable and passed in to `errgroup.Go` call.

* Finish Removing `golint`

Removed remaining references to `golint` in dev doc, Makefile,
bash scripts, and powershell build scripts.
Removed `get_dev_tools.sh` and `get_dev_tools.ps1` as they only install
the removed `golint` package.
This commit is contained in:
Rob Lee
2021-12-11 16:09:03 +00:00
committed by GitHub
parent 2f49984800
commit 567c939ac4
8 changed files with 8 additions and 21 deletions
+2 -2
View File
@@ -234,10 +234,10 @@ Then open [http://localhost:1313](http://localhost:1313/).
# Linting
In our CI/CD pass, we use golint, so feel free to install and run it locally beforehand:
In our CI/CD pass, we use govet, so feel free to run it locally beforehand:
```
go get golang.org/x/lint/golint
go vet ./...
```
# For People Doing a Release