Replace `golint` with `go vet`– #1743 (#1744)

mirror of https://github.com/gomods/athens synced 2026-02-03 08:40:31 +00:00

* Set GO111MODULE to auto in golint script– #1743

As mentioned in #1743 the Go modules environment flag is set to `off`
in the script which appears to cause a warning message for each module
of the codebase that it is "not in GOROOT".

Set to `auto` as this allows the same build to be run the original way
should someone choose to delete the `go.mod` file from the project root.

* Remove redundant code – golint script

Go 1.17 ignores `GO111MODULE` and there are no directories in the
project root called `mock`.

* Replace `golint` with `go vet`

`golint` is deprecated (and frozen) replace with the current `go vet`.
This reported one issue on `main` branch:
```pkg/stash/with_etcd.go:33:28:
loop variable ep captured by func literal```

Fixed loop variable capture with extraction to parameterised anonymous
function passed loop variable and passed in to `errgroup.Go` call.

This commit is contained in:

Rob Lee

2021-12-10 06:03:48 +00:00

committed by

GitHub

parent 898673c600

commit 918ddfb59a

3 changed files with 9 additions and 6 deletions

									
										scripts/check_golint.sh → scripts/check_govet.sh
									
		+1
		-1
	
												View File
												
				@@ -4,4 +4,4 @@

				# Run the linter on everything except generated code

				set -euo pipefail

				golint -set_exit_status $(GO111MODULE=off go list ./... | grep -v '/mocks')

				go vet ./...

Replace golint with go vet– #1743 (#1744)

Replace `golint` with `go vet`– #1743 (#1744)