fix release workflow (#1831)

* fix release workflow

* test release

* remove test changes

* add version tag to release workflow

---------

Co-authored-by: Manu Gupta <manugupt1@gmail.com>

.github/workflows/release.canary.yml

@@ -21,9 +21,14 @@ jobs:
           file: cmd/proxy/Dockerfile
           build-args: VERSION=${{github.sha}}
           tags: gomods/athens:canary
+          push: true
+      - name: Set Short SHA
+        id: vars
+        run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
       - name: Build and push commit tag
         uses: docker/build-push-action@v4
         with:
           file: cmd/proxy/Dockerfile
           build-args: VERSION=${{github.sha}}
-          tags: gomods/athens-dev:${GITHUB_SHA::7}
+          tags: gomods/athens-dev:${{ steps.vars.outputs.sha_short }}
+          push: true

.github/workflows/release.latest.yml

@@ -19,5 +19,6 @@ jobs:
         uses: docker/build-push-action@v4
         with:
           file: cmd/proxy/Dockerfile
-          build-args: VERSION=${{github.sha}}
-          tags: gomods/athens:latest
+          build-args: VERSION=${{ github.ref_name }}
+          tags: gomods/athens:latest,gomods/athens:${{ github.ref_name }}
+          push: true