chore: lint code with golangci-lint (#1828)

* feat: add golangci-lint linting

* chore: fix linter issues

* feat: add linting into the workflow

* docs: update lint docs

* fix: cr suggestions

* fix: remove old formatting and vetting scripts

* fix: add docker make target

* fix: action go caching

* fix: depreciated actions checkout version

* fix: cr suggestion

* fix: cr suggestions

---------

Co-authored-by: Manu Gupta <manugupt1@gmail.com>

scripts/ps/check_gofmt.ps1

@@ -1,7 +0,0 @@
-# check_gofmt.ps1
-# Fail if a .go file hasn't been formatted with gofmt
-$GO_FILES = Get-ChildItem -Recurse -Filter *.go  -Name | Select-String -Pattern $(Join-Path "vendor" -ChildPath ".*") -NotMatch
-$out = & gofmt -s -l $GO_FILES
-if ($out.length -gt 0) {
-    Write-Error $out
-}

scripts/ps/check_govet.ps1

@@ -1,7 +0,0 @@
-# check_govet.ps1
-# Run the linter on everything
-
-$out = & go vet ./...
-if ($LastExitCode -ne 0) {
-    Write-Error $out
-}