mirror of
https://github.com/gomods/athens
synced 2026-02-03 12:10:32 +00:00
[s3] base uri is not used anywhere remove it (#1293)
* base uri is not used anywhere remove it * remove from struct
This commit is contained in:
committed by
Aaron Schlesinger
parent
9436778be0
commit
e5173c57cd
@@ -1,8 +1,6 @@
|
||||
package s3
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"net/url"
|
||||
"time"
|
||||
|
||||
"github.com/aws/aws-sdk-go/aws"
|
||||
@@ -25,7 +23,6 @@ import (
|
||||
// For information how to get your keyId and access key turn to official aws docs: https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/setting-up.html
|
||||
type Storage struct {
|
||||
bucket string
|
||||
baseURI *url.URL
|
||||
uploader s3manageriface.UploaderAPI
|
||||
s3API s3iface.S3API
|
||||
timeout time.Duration
|
||||
@@ -34,10 +31,6 @@ type Storage struct {
|
||||
// New creates a new AWS S3 CDN saver
|
||||
func New(s3Conf *config.S3Config, timeout time.Duration, options ...func(*aws.Config)) (*Storage, error) {
|
||||
const op errors.Op = "s3.New"
|
||||
u, err := url.Parse(fmt.Sprintf("https://%s.s3.amazonaws.com", s3Conf.Bucket))
|
||||
if err != nil {
|
||||
return nil, errors.E(op, err)
|
||||
}
|
||||
|
||||
creds := buildAWSCredentials(s3Conf)
|
||||
|
||||
@@ -61,7 +54,6 @@ func New(s3Conf *config.S3Config, timeout time.Duration, options ...func(*aws.Co
|
||||
bucket: s3Conf.Bucket,
|
||||
uploader: uploader,
|
||||
s3API: uploader.S3,
|
||||
baseURI: u,
|
||||
timeout: timeout,
|
||||
}, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user