mirror of
https://github.com/gomods/athens
synced 2026-02-03 11:00:32 +00:00
9e76722acc
* Add Dependencies for GCP
cloud.google.com/go/storage
google.golang.org/api/option // allows authetication options for storage
github.com/golang/protobuf // override to fix dependency issue
issue was with a protobuf library required by the storage library.
it was importing v1.0.0 but referencing code from v1.1.0
* WIP mostly roughed out
some small descisions to be made and testing is missing
* rename gcp.go to saver.go
* rename gcp.go to saver.go
* Requested Changes
+ closing the storage.Client is not required
+ move increment of count into 'for' line
+ add tracing span for save helper
+ removed projectID from New signiture, unused
* basic test, just testing generator so far
* Readability fixes
+ change calls to save so they send directly to the errs channel
+ return wc.Close instead of checking the error first
+ also remove failing part of tests for now, needs authentication
* Happy Path Tests
- removed use of buffalo.Context
- (storage).Save no longer accepts a context
+ includes basic happy path tests
+ private key for test project praxis-cab-207400.appspot.com
* messy gitwork
* remove keys
* ch-ch-changes🎶
+ defer close of storage.Writer, logging to be decided
+ correct check on length of errsOut
+ set inital length of errsOut to 0
* more stuff is in here
+ switch to context being passed again
+ use context with timeout instead of time.After
+ tests pull creds from env variable
missing skipping tests when no variable is set and teardown is no
implemented
* skip gcp storage tests when no key file present
* speed up tests a little
* need aetest pkg
* add aetest to Gopkg.toml explicitly
* tear down suite deletes storage artifacts
* should setup whole suite
* log error on wc.close and close errs chan
* cleaner check for env var
* use envy where appropriate and pull gcp bucket name from env var
* one more for consistency
I like the comma ok idiom better in this case but everything else is
using envy.
* don't panic in test set up and tear down
* use shared context with timeout and switch to seconds for duration
* no one needed the context.Cancel func. use `file` instead of `content` for consistency
* defer cancellation of context for uploads
* Update saver.go
+ rename `save` to `upload`
+ clarify comments