primal/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2026-02-03 08:50:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use reserved .test TLD for unit tests (#36498)

Browse Source 
`smtp.mydomain.test` is a real domain that resolves to something and
which is being connected to while running tests. Instead, use
[.test](https://en.wikipedia.org/wiki/.test) which is guaranteed to
never be registered on the internet, so all connections to it will fail
with NXDOMAIN dns error.
This commit is contained in:
silverwind
2026-01-30 20:42:32 +01:00
committed by GitHub
parent 208cbd5a6f
commit 2d1306291b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/setting/mailer_test.go
+4 -4
View File
@@ -11,12 +11,12 @@ import (
func Test_loadMailerFrom(t *testing.T) { func Test_loadMailerFrom(t *testing.T) {
kases := map[string]*Mailer{ kases := map[string]*Mailer{
"smtp.mydomain.com": { "smtp.mydomain.test": {
SMTPAddr: "smtp.mydomain.com", SMTPAddr: "smtp.mydomain.test",
SMTPPort: "465", SMTPPort: "465",
}, },
"smtp.mydomain.com:123": { "smtp.mydomain.test:123": {
SMTPAddr: "smtp.mydomain.com", SMTPAddr: "smtp.mydomain.test",
SMTPPort: "123", SMTPPort: "123",
}, },
":123": { ":123": {