Clean up error operation names to match function names. (#614)

pkg/download/version_info.go

@@ -14,7 +14,7 @@ const PathVersionInfo = "/{module:.+}/@v/{version}.info"
 
 // VersionInfoHandler implements GET baseURL/module/@v/version.info
 func VersionInfoHandler(dp Protocol, lggr log.Entry, eng *render.Engine) buffalo.Handler {
-	const op errors.Op = "download.versionInfoHandler"
+	const op errors.Op = "download.VersionInfoHandler"
 	return func(c buffalo.Context) error {
 		mod, ver, err := getModuleParams(c, op)
 		if err != nil {

pkg/middleware/filter.go

@@ -14,7 +14,7 @@ import (
 // NewFilterMiddleware builds a middleware function that implements the filters configured in
 // the filter file.
 func NewFilterMiddleware(mf *module.Filter, olympusEndpoint string) buffalo.MiddlewareFunc {
-	const op errors.Op = "actions.FilterMiddleware"
+	const op errors.Op = "actions.NewFilterMiddleware"
 
 	return func(next buffalo.Handler) buffalo.Handler {
 		return func(c buffalo.Context) error {

pkg/middleware/validation.go

@@ -14,7 +14,7 @@ import (
 // NewValidationMiddleware builds a middleware function that performs validation checks by calling
 // an external webhook
 func NewValidationMiddleware(entry log.Entry, validatorHook string) buffalo.MiddlewareFunc {
-	const op errors.Op = "actions.ValidationMiddleware"
+	const op errors.Op = "actions.NewValidationMiddleware"
 
 	return func(next buffalo.Handler) buffalo.Handler {
 		return func(c buffalo.Context) error {

pkg/module/disk_ref.go

@@ -50,7 +50,7 @@ func newDiskRef(fs afero.Fs, root, module, version string) *diskRef {
 // ClearFiles deletes all data from the given fs at path root
 // This function must be called when zip is closed to cleanup the entire GOPATH created by the diskref
 func ClearFiles(fs afero.Fs, root string) error {
-	const op errors.Op = "clearFiles"
+	const op errors.Op = "ClearFiles"
 	// This is required because vgo ensures dependencies are read-only
 	// See https://github.com/golang/go/issues/24111 and
 	// https://go-review.googlesource.com/c/vgo/+/96978